Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references to source code in compilation buffer for rustc 1.24 #56

Merged
merged 1 commit into from
May 21, 2018

Conversation

Dushistov
Copy link
Contributor

This change is based on #55
It uses cargo-process--custom-path-to-bin instead of hard coded
"cargo", plus it uses --manifest-path to run "cargo" against only one crate.

This change is based on kwrooijen#55
It uses cargo-process--custom-path-to-bin instead of hard coded
"cargo", plus it uses --manifest-path to run "cargo" against only one crate.
@Dushistov
Copy link
Contributor Author

Known problem: if Cargo.toml mailformed, it reports JSON error, better will be report cargo stderr instead

@kwrooijen
Copy link
Owner

Would this PR completely invalidate #55 ?

Also I think the Cargo.toml issue is a bit trivial IMHO.

@Dushistov
Copy link
Contributor Author

Dushistov commented May 21, 2018

Would this PR completely invalidate #55 ?

Yes. #55 has issue - it re-builds the whole workspace, instead of current crate.
That was very inconvenient for me, and that's why I took #55 and redid.

Also I think the Cargo.toml issue is a bit trivial IMHO.

The current PR and #55 is pretty trivial, so feel free to close both PR and redo
this functionality from scratch without trivial to solve problems.

@kwrooijen
Copy link
Owner

I'll merge this and see if I have time to fix the Json issue. But really if it only occurs when you have malformed data I don't think it's a big issue. I'll close the other PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants