-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Istio 1.20.0-distroless images to external-images.yaml for image-syncer #9357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
needs-kind
needs-area
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Nov 21, 2023
videlov
added
area/service-mesh
Issues or PRs related to service-mesh
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Nov 21, 2023
videlov
added
kind/feature
Categorizes issue or PR as related to a new feature.
needs-area
labels
Nov 21, 2023
Plan Result
Change Result (Click me) # module.artifact_registry["modules-internal"].google_artifact_registry_repository.artifact_registry will be updated in-place
~ resource "google_artifact_registry_repository" "artifact_registry" {
id = "projects/kyma-project/locations/europe/repositories/modules-internal"
name = "modules-internal"
# (11 unchanged attributes hidden)
+ docker_config {
+ immutable_tags = false
}
}
# module.service_account_keys_cleaner.google_cloud_scheduler_job.service_account_keys_cleaner will be updated in-place
~ resource "google_cloud_scheduler_job" "service_account_keys_cleaner" {
id = "projects/sap-kyma-prow/locations/europe-west3/jobs/service-account-keys-cleaner"
name = "service-account-keys-cleaner"
# (8 unchanged attributes hidden)
~ http_target {
~ uri = "https://service-account-keys-cleaner-q25ja7ch3q-ez.a.run.app/?project=sap-kyma-prow&age=24" -> "https://service-account-keys-cleaner-q25ja7ch3q-ez.a.run.app?project=sap-kyma-prow&age=24"
# (2 unchanged attributes hidden)
# (1 unchanged block hidden)
}
}
Plan: 0 to add, 2 to change, 0 to destroy.
Changes to Outputs:
~ artifact_registry = {
~ modules-internal = {
~ artifact_registry_collection = {
id = "projects/kyma-project/locations/europe/repositories/modules-internal"
name = "modules-internal"
~ update_time = "2023-11-21T09:59:32.235615Z" -> "2023-11-21T10:41:17.522219Z"
# (16 unchanged attributes hidden)
}
}
} ℹ️ Objects have changed outside of TerraformThis feature was introduced from Terraform v0.15.4. OpenTofu detected the following changes made outside of OpenTofu since the
last "tofu apply" which may have affected this plan:
# module.artifact_registry["modules-internal"].google_artifact_registry_repository.artifact_registry has changed
~ resource "google_artifact_registry_repository" "artifact_registry" {
id = "projects/kyma-project/locations/europe/repositories/modules-internal"
name = "modules-internal"
~ update_time = "2023-11-21T10:10:17.531410Z" -> "2023-11-21T10:41:17.522219Z"
# (10 unchanged attributes hidden)
}
Unless you have made equivalent changes to your configuration, or ignored the |
the1bit
approved these changes
Nov 21, 2023
@videlov if you can't remove manually area labels, please use /label command when you write description of your PR |
This comment has been minimized.
This comment has been minimized.
15 tasks
videlov
changed the title
Add Istio 1.12.0 distroless images to external-images.yaml for image-syncer
Add Istio 1.20.0-distroless images to external-images.yaml for image-syncer
Nov 21, 2023
kyma-bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add-or-update
area/service-mesh
Issues or PRs related to service-mesh
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Looks good to me!
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)