Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Istio 1.20.0-distroless images to external-images.yaml for image-syncer #9357

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

videlov
Copy link
Contributor

@videlov videlov commented Nov 21, 2023

Description

Changes proposed in this pull request:

  • Add Istio 1.20.0-distroless images to external-images.yaml for image-syncer

Related issue(s)

@kyma-bot kyma-bot added needs-kind needs-area size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2023
@videlov videlov added area/service-mesh Issues or PRs related to service-mesh and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2023
@videlov videlov added kind/feature Categorizes issue or PR as related to a new feature. needs-area labels Nov 21, 2023
Copy link

Plan Result

CI link

Plan: 0 to add, 2 to change, 0 to destroy.
  • Update
    • module.artifact_registry["modules-internal"].google_artifact_registry_repository.artifact_registry
    • module.service_account_keys_cleaner.google_cloud_scheduler_job.service_account_keys_cleaner
Change Result (Click me)
  # module.artifact_registry["modules-internal"].google_artifact_registry_repository.artifact_registry will be updated in-place
  ~ resource "google_artifact_registry_repository" "artifact_registry" {
        id               = "projects/kyma-project/locations/europe/repositories/modules-internal"
        name             = "modules-internal"
        # (11 unchanged attributes hidden)

      + docker_config {
          + immutable_tags = false
        }
    }

  # module.service_account_keys_cleaner.google_cloud_scheduler_job.service_account_keys_cleaner will be updated in-place
  ~ resource "google_cloud_scheduler_job" "service_account_keys_cleaner" {
        id               = "projects/sap-kyma-prow/locations/europe-west3/jobs/service-account-keys-cleaner"
        name             = "service-account-keys-cleaner"
        # (8 unchanged attributes hidden)

      ~ http_target {
          ~ uri         = "https://service-account-keys-cleaner-q25ja7ch3q-ez.a.run.app/?project=sap-kyma-prow&age=24" -> "https://service-account-keys-cleaner-q25ja7ch3q-ez.a.run.app?project=sap-kyma-prow&age=24"
            # (2 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }
    }

Plan: 0 to add, 2 to change, 0 to destroy.

Changes to Outputs:
  ~ artifact_registry                                   = {
      ~ modules-internal = {
          ~ artifact_registry_collection = {
                id                        = "projects/kyma-project/locations/europe/repositories/modules-internal"
                name                      = "modules-internal"
              ~ update_time               = "2023-11-21T09:59:32.235615Z" -> "2023-11-21T10:41:17.522219Z"
                # (16 unchanged attributes hidden)
            }
        }
    }
ℹ️ Objects have changed outside of Terraform

This feature was introduced from Terraform v0.15.4.

OpenTofu detected the following changes made outside of OpenTofu since the
last "tofu apply" which may have affected this plan:

  # module.artifact_registry["modules-internal"].google_artifact_registry_repository.artifact_registry has changed
  ~ resource "google_artifact_registry_repository" "artifact_registry" {
        id               = "projects/kyma-project/locations/europe/repositories/modules-internal"
        name             = "modules-internal"
      ~ update_time      = "2023-11-21T10:10:17.531410Z" -> "2023-11-21T10:41:17.522219Z"
        # (10 unchanged attributes hidden)
    }


Unless you have made equivalent changes to your configuration, or ignored the

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 21, 2023
@Ressetkk
Copy link
Contributor

@videlov if you can't remove manually area labels, please use /label command when you write description of your PR
/check-required-labels

@kyma-bot kyma-bot merged commit 983a29f into main Nov 21, 2023
7 checks passed

This comment has been minimized.

@videlov videlov mentioned this pull request Nov 21, 2023
15 tasks
@videlov videlov changed the title Add Istio 1.12.0 distroless images to external-images.yaml for image-syncer Add Istio 1.20.0-distroless images to external-images.yaml for image-syncer Nov 21, 2023
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2023
@Ressetkk Ressetkk deleted the videlov-patch-1 branch November 24, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-or-update area/service-mesh Issues or PRs related to service-mesh kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants