-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripping other metadata (execute time) #34
Comments
I suppose stripping all but whitelisted metadata would make sense. How do you envision configuring that whitelist? |
@jdriordan, are you still planning to submit a pr for this? |
Sorry for the delay. One way to do a whitelist would be to start with those given in the format spec, i.e.
along with those used by
People seem to be using metadata for other various things in the wild (author/description etc.) and it's also used by some extensions (which could register themselves on the whitelist, in theory). Having looked at all this I've managed to convince myself a blacklist is a more sensible option (since other metadata doesn't change in a useless way like this does. So I've ended up making a really simple change that just strips this one field (but could trivially do others too). PR submitted. |
I agree with your rationale about blacklisting rather than whitelisting. PR merged! |
time to release maybe? ;) |
@michaelaye This is actually already released in 0.2.9 |
I'm using the (hugely useful)
Execute Time
nbextension, which produces cell metadata like this:But naturally I end up with a load of changes seen by git after running
nbstripout
because of re-running the cells and updating theExecuteTime
field. Would you accept a pull request explicitly stripping this out, or alternatively one which strips all but whitelisted metadata entries?The text was updated successfully, but these errors were encountered: