fix: write report in format json #1538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Winton <jwinton@squareup.com>
jonwinton
force-pushed
the
jonwinton/fix-json-report
branch
from
c2a4281
to
098aac6
Compare
|
Closing, done in #1962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR's goal is to fix a bug that came up in
v0.2.0where reports are not being created when using a format of typeJSON.Related issue
#1537
Proposed Changes
It looks like in #1190 that the JSON report type support was removed but the case still exists. This just re-implements the old logic.
Checklist
Further Comments
There are existing tests which declare a type of
JSONin their formatter and so there is "coverage" but the error state of the JSON failing to marshal is not tested.