Add LiveKit as example #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3396669949
💛 - Coveralls |
VidarHUN
reviewed
Nov 4, 2022
examples/livekit/README.md
Outdated
| - deploy the LiveKit server into Kubernetes | ||
| - configure STUNner to expose LiveKit to clients | ||
|
|
||
| ## Intallation |
VidarHUN
reviewed
Nov 4, 2022
examples/livekit/README.md
Outdated
|
|
||
| ## Setup | ||
|
|
||
| The figure below shows how LiveKit is deployed into Kubernetes without the contstraints of running in host network (`hostNetwork: true`). In this setup LiveKit uses STUNner as a 'local' `STUN` and `TURN` server which enhances the security and saves the overhead cost of using public a `STUN` server. |
There was a problem hiding this comment.
saves the overhead cost of using public a STUN server. Is it a notable overhead?
VidarHUN
reviewed
Nov 4, 2022
examples/livekit/README.md
Outdated
|
|
||
| ## Installation guide | ||
|
|
||
| Let's start with a disclaimer. The LiveKit client example(browser) must have secure HTTP connection in order to work because, [getUserMedia](https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia#browser_compatibility) is available only in secure contexts. This induces that the client-server(LiveKit-server) connection must be secure too. According to the [docs](https://docs.livekit.io/deploy/#domain,-ssl-certificates,-and-load-balancer) and our experiences, self-signed certs do not work. |
There was a problem hiding this comment.
HTTP -> HTTPS
Self-signed certs works for the getUserMedia, etc... but will not work with secure websocket. So, we should mention that.
rg0now
approved these changes
Nov 4, 2022
|
This is fantastic, thanks! Couple of minor comments in closing:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally adding the so-awaited LiveKit demo.
Issuing: #22
Features:
hostNetwork: true) anymore