Fix Andorid API 31 Pending Intent Crash #41

masterwok · 2022-04-27T15:34:31Z

This pull request fixes a crash that occurs when receiving a push notification on Android API 31+ (#40)

This crash was due to the Android Iterable SDK not setting mutability on a PendingIntent.

The fix was to bump the Android Iterable SDK to version 3.4.2 as discussed here: Iterable/iterable-android-sdk#430

Other changes:

Bumped Kotlin version to 1.6.21 (had to bump to support API 31 so bumped to latest)
flutter pub get implicitly upgraded other packages

I wasn't sure what versioning strategy you use so I didn't bump the iterable-flutter package version.

Below is a video demonstrating the fix:

Screen.Recording.2022-04-27.at.11.19.14.AM.mov

justinelliss-coinme · 2022-04-27T15:41:51Z

Thanks man - this resolves an issue we were having

Santi92

Excellent for your contribution and solving this bug in Android API 31. 🎊 🎸

I left you some comments about changes that don't go with this fix.

Santi92 · 2022-04-27T20:27:34Z

example/pubspec.lock

+    version: "0.12.11"
+  material_color_utilities:
+    dependency: transitive
+    description:
+      name: material_color_utilities
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.1.3"


I don't understand how there are changes in the pubspec.lock but there are no changes in the pubspec.yaml, WDYT ?

Or it could be that you missed it in the PR by mistake, or if you made a change to the example to improve it, it would be great if you did it in another PR.

I ran flutter pub get in the root of the project and these packages were implicitly updated. I didn't change anything in the example project.

jonathantrowbridge@Jonathans-MacBook-Pro-2  ~/projects/iterable-flutter   master  git status On branch master Your branch is up to date with 'origin/master'. nothing to commit, working tree clean jonathantrowbridge@Jonathans-MacBook-Pro-2  ~/projects/iterable-flutter   master  flutter pub get Running "flutter pub get" in iterable-flutter... 909ms Running "flutter pub get" in example... 1,089ms jonathantrowbridge@Jonathans-MacBook-Pro-2  ~/projects/iterable-flutter   master ●  git status On branch master Your branch is up to date with 'origin/master'. Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) modified: example/pubspec.lock modified: pubspec.lock no changes added to commit (use "git add" and/or "git commit -a")

I just searched around a bit and it looks like dart.dev recommends against committing pubspec.dart for library packages. More information:

From the documentation:

pubspec.lock

The pubspec.lock file is a special case, similar to Ruby’s Gemfile.lock.

For library packages, don’t commit the pubspec.lock file. Regenerating the pubspec.lock file lets you test your >package against the latest compatible versions of its dependencies.

For application packages, we recommend that you commit the pubspec.lock file. Saving pubspec.lock ensures that everyone working on the app uses the exact same versions._

https://dart.dev/guides/libraries/private-files#pubspeclock

https://stackoverflow.com/a/64750701/563509

@Santi92 how would you like me to handle the pubspec.lock file? Once we get this merged down I have another PR I'd like to submit for review. This PR adds support for tracking event data on iOS and Android: masterwok#1

Santi92 · 2022-04-27T20:28:32Z

pubspec.lock

+    version: "0.12.11"
+  material_color_utilities:
+    dependency: transitive
+    description:
+      name: material_color_utilities
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.1.3"


Same here. changes in the pubspec.lock but there are no changes in the pubspec.yaml

Santi92 · 2022-04-27T20:28:32Z

pubspec.lock

+    version: "0.12.11"
+  material_color_utilities:
+    dependency: transitive
+    description:
+      name: material_color_utilities
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.1.3"


Same here. changes in the pubspec.lock but there are no changes in the pubspec.yaml

danielgomezrico

@Masterwork thanks for the PR! I left some minor questions, and can you please do a rebase with master? I made a fix to see if your PR works fine for android on #44.

danielgomezrico · 2022-05-02T14:37:59Z

android/build.gradle

@@ -2,7 +2,7 @@ group 'com.lahaus.iterable_flutter'
 version '1.0-SNAPSHOT'

 buildscript {
-    ext.kotlin_version = '1.3.50'


Do we need to update kotlin for this?

From my understanding, I believe so. When I bumped compileSdkVersion 31 without updating the Kotlin version it resulted in the following error:

* What went wrong: Execution failed for task ':iterable_flutter:compileDebugKotlin'. > Compilation error. See log for more details * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 11s ┌─ Flutter Fix ────────────────────────────────────────────────────────────────────────────────┐ │ [!] Your project requires a newer version of the Kotlin Gradle plugin. │ │ Find the latest version on https://kotlinlang.org/docs/gradle.html#plugin-and-versions, then │ │ update /Users/jt/projects/iterable-flutter/example/android/build.gradle: │ │ ext.kotlin_version = '<latest-version>' │ └──────────────────────────────────────────────────────────────────────────────────────────────┘

Because of this, I decided to bump to latest. I just noticed one thing however, we should probably bump targetSdkVersion to match the compileSdkVersion. I'm going to push up that change now.

danielgomezrico · 2022-05-02T14:38:09Z

example/android/build.gradle

@@ -1,5 +1,5 @@
 buildscript {
-    ext.kotlin_version = '1.3.50'


masterwok · 2022-05-03T13:46:18Z

@Santi92 @Santi92 sorry, had to close this PR. Going to open again. I accidentally pushed something I didn't mean to 🙃 . Sorry about that.

masterwok · 2022-05-03T13:51:21Z

Reopened under due to mistake: #46

masterwok requested review from danielgomezrico, cdmunoz, Santi92 and juansoos as code owners April 27, 2022 15:34

Santi92 suggested changes Apr 27, 2022

View reviewed changes

Santi92 mentioned this pull request May 2, 2022

feat(Library Pubspec): add pubspec to the ignore file by recommendation #43

Merged

danielgomezrico reviewed May 2, 2022

View reviewed changes

masterwok closed this May 3, 2022

masterwok force-pushed the bugfix/android-api-31-crash branch from 8bee2bb to 00b488d Compare May 3, 2022 13:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Andorid API 31 Pending Intent Crash #41

Fix Andorid API 31 Pending Intent Crash #41

masterwok commented Apr 27, 2022 •

edited

Loading

justinelliss-coinme commented Apr 27, 2022

Santi92 left a comment

Santi92 Apr 27, 2022

masterwok Apr 29, 2022

masterwok Apr 29, 2022

masterwok Apr 29, 2022

Santi92 Apr 27, 2022

Santi92 Apr 27, 2022

danielgomezrico left a comment

danielgomezrico May 2, 2022

masterwok May 3, 2022

danielgomezrico May 2, 2022

masterwok commented May 3, 2022

masterwok commented May 3, 2022

Fix Andorid API 31 Pending Intent Crash #41

Fix Andorid API 31 Pending Intent Crash #41

Conversation

masterwok commented Apr 27, 2022 • edited Loading

justinelliss-coinme commented Apr 27, 2022

Santi92 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danielgomezrico left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

masterwok commented May 3, 2022

masterwok commented May 3, 2022

masterwok commented Apr 27, 2022 •

edited

Loading