Fix Crash on API 31+ #46
Merged
+21
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterwok
requested review from
danielgomezrico,
cdmunoz,
Santi92 and
juansoos
as code owners
danielgomezrico
approved these changes
May 3, 2022
Santi92
approved these changes
May 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, this is a duplicate of my previous PR. I had to delete the first one because I committed something that shouldn't have been pushed up.
This pull request fixes a crash that occurs when receiving a push notification on Android API 31+ (#40)
This crash was due to the Android Iterable SDK not setting mutability on a PendingIntent.
The fix was to bump the Android Iterable SDK to version 3.4.2 as discussed here: Iterable/iterable-android-sdk#430
Other changes:
flutter pub getimplicitly upgraded other packagesI wasn't sure what versioning strategy you use so I didn't bump the iterable-flutter package version.
Below is a video demonstrating the fix:
Screen.Recording.2022-04-27.at.11.19.14.AM.mov