Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions instructions #38

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Apr 30, 2024

This fixes the issue pointed out in #4 (comment)

One subtle issue is that when printing the exception, line breaks were
being inserted according to the terminal width. To avoid this, I broke the
command into short lines.

The error now reads:

```
UsbDeviceError:

You do not have sufficient access to the device. You probably want to add the a udev
rule in /etc/udev/rules.d with the following command:

    echo 'ACTION=="add",'\
         'SUBSYSTEMS=="usb",'\
         'ATTRS{idVendor}=="0922",'\
         'ATTRS{idProduct}=="1001",'\
         'MODE="0666"' \
      | sudo tee /etc/udev/rules.d/91-labelle-0922-1001.rules

Next, refresh udev with:

    sudo udevadm control --reload-rules
    sudo udevadm trigger --attr-match=idVendor="0922"

Finally, turn your device off and back on again to activate the new permissions.

If this still does not resolve the problem, you might need to reboot.
In case rebooting is necessary, please report this at <labelle-org#6>.
We are still trying to figure out a simple procedure which works for everyone.
In case you still cannot connect, or if you have any information or ideas, please
post them at that link.
```
Copy link
Contributor

@tomers tomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@maresb maresb merged commit a940342 into labelle-org:main Apr 30, 2024
6 checks passed
@maresb maresb deleted the fix-permissions-instructions branch April 30, 2024 11:06
@maresb
Copy link
Contributor Author

maresb commented Apr 30, 2024

@tomers, would you like to cut a patch release for this?

@tomers
Copy link
Contributor

tomers commented May 1, 2024

@maresb, I tried creating a new release, and failed: https://github.com/labelle-org/labelle/actions/runs/8914282659
I've also added a PR for capturing instructions on how to release, based on your comment in some other PR: #41

Please advise how to resolve the relase issue.

@maresb
Copy link
Contributor Author

maresb commented May 2, 2024

Hi @tomers, I think I see the issue. You tagged the release as 1.2.2, but the branch protection rules expect v1.2.2.

image

That corresponds to the error message:

image

You could try editing the release and changing the tag to v1.2.2, but I'm not sure that will trigger a new CI run. If you delete the release and delete the tag, you should be able to publish a new release.

Just in case you run into trouble with "Generate release notes" after deleting the current release, I've copied it below for safety:


This is mainly a maintenance relase, with no new-features.

What's Changed

Maintenance

Full Changelog: v1.2.1...1.2.2

sudo udevadm control --reload-rules
sudo udevadm trigger --attr-match=idVendor="0922"
sudo udevadm control --reload-rules
sudo udevadm trigger --attr-match=idVendor="0922"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is sudo udevadm trigger not sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants