Added exports field to package.json #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chudoklates
requested review from
kgrhartlage and
ignatiusreza
as code owners
kgrhartlage
reviewed
Oct 18, 2022
package.json
Outdated
Comment on lines
13
to
19
| "exports": { | ||
| ".": { | ||
| "default": "./dist/index.js", | ||
| "require": null | ||
| } | ||
| }, | ||
| "main": "dist/index.js", |
There was a problem hiding this comment.
What's the benefit of this exports field as opposed to just main? IIUC one or the other is obsolete, no?
There was a problem hiding this comment.
I believe main is still used as fallback in case exports cannot be used
chudoklates
commented
Oct 18, 2022
| "exports": { | ||
| ".": { | ||
| "require": null, | ||
| "default": "./dist/index.js" |
There was a problem hiding this comment.
default needs to be the last property for this to work
kgrhartlage
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤦