refactor(structure): universal-addon template migration #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaygridley
changed the title
jaygridley
changed the title
atyu1
requested changes
Aug 8, 2025
| helm_argo_application_enabled = var.enabled && var.argo_enabled && var.argo_helm_enabled | ||
| helm_argo_application_wait_enabled = local.helm_argo_application_enabled && length(keys(var.argo_kubernetes_manifest_wait_fields)) > 0 | ||
| helm_argo_application_values = [ | ||
| helm_argo_application_enabled = var.enabled == true && var.argo_enabled == true && var.argo_helm_enabled == true |
There was a problem hiding this comment.
Probably not, but this originates in the universal-addon. If we want to tackle this, we should do it there.
| config = { | ||
| zones = { | ||
| ".:53" = { | ||
| plugins = { |
There was a problem hiding this comment.
We have plenty of values, which got deleted, those were default values?
There was a problem hiding this comment.
Yes, same as in the Helm chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
fix)feat)refactor)test)style)ci)docs)This PR migrates addon structure to the https://github.com/lablabs/terraform-aws-eks-universal-addon template.
How Has This Been Tested?
Compared deployment behaviour with old and new version. Looking same.
Compared CoreDNS configuration of old and new version. It is same.