refactor: Merge kernels.role into sessions.session_type
#1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
fregataa
force-pushed
the
fix/replace-kernelrole-to-sessiontype
branch
from
7f7864f
to
7b2839b
Compare
github-actions
bot
added
impact:invisible
|
We need to do a follow-up fix for #2746 (comment) after merging this PR and the stack including #2848. |
achimnol
approved these changes
Sep 20, 2024
lablup-octodog
pushed a commit
that referenced
this pull request
Sep 20, 2024
Co-authored-by: Joongi Kim <joongi@lablup.com> Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 1587
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 21, 2024
…2854) Co-authored-by: Sanghun Lee <sanghun@lablup.com> Co-authored-by: Joongi Kim <joongi@lablup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1446 and supersedes #1455.
According to the predefined concept, the
kernels.rolefield should be replaced by thesessions.session_typefield. Also check if the image'sai.backend.rolelabel is compatible with the session type when the label is defined.ref) https://docs.backend.ai/en/latest/concepts/computing.html#session-types
This PR also fixes wrong cases to decrement the per-access-key session concurrency when force-terminating non-running sessions, by skipping decrements for TERMINATED and CANCELLED sessions.
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--1587.org.readthedocs.build/en/1587/
📚 Documentation preview 📚: https://sorna-ko--1587.org.readthedocs.build/ko/1587/