fix: Safe access to _health_check_task for non-model serving kernels
#1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:general
.fix.md -> 1764.fix.md
rapsealk
added
comp:agent
achimnol
reviewed
Dec 7, 2023
src/ai/backend/kernel/base.py
Outdated
| @@ -190,6 +190,9 @@ def __init__(self, runtime_path: Path) -> None: | |||
| # build status tracker to skip the execute step | |||
| self._build_success = None | |||
|
|
|||
| # initialize _health_check_status explicitly to `None` | |||
There was a problem hiding this comment.
This type of comment is just a redundancy.
Instead, I'd suggest to mention that this attribute is initialized and used by another module.
achimnol
approved these changes
Dec 7, 2023
achimnol
pushed a commit
that referenced
this pull request
Dec 7, 2023
#1764) Backported-from: main Backported-to: 23.09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #1606 and resolves #1763 by enforce safe access to the
_health_check_taskattribute of the kernel runner, which is used only for model-service kernels.Checklist: (if applicable)