Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Safe access to _health_check_task for non-model serving kernels #1764

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

rapsealk
Copy link
Member

@rapsealk rapsealk commented Dec 7, 2023

This PR is a follow-up of #1606 and resolves #1763 by enforce safe access to the _health_check_task attribute of the kernel runner, which is used only for model-service kernels.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Documentation
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to demonstrate the difference of before/after

@rapsealk rapsealk added this to the 23.09 milestone Dec 7, 2023
@rapsealk rapsealk self-assigned this Dec 7, 2023
@github-actions github-actions bot added platform:general General platform issues. Most issues are general. type:bug Reports about that are not working labels Dec 7, 2023
@github-actions github-actions bot added the size:XS ~10 LoC label Dec 7, 2023
@rapsealk rapsealk added comp:agent Related to Agent component and removed comp:agent Related to Agent component labels Dec 7, 2023
@github-actions github-actions bot added size:S 10~30 LoC and removed size:XS ~10 LoC labels Dec 7, 2023
@@ -190,6 +190,9 @@ def __init__(self, runtime_path: Path) -> None:
# build status tracker to skip the execute step
self._build_success = None

# initialize _health_check_status explicitly to `None`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type of comment is just a redundancy.
Instead, I'd suggest to mention that this attribute is initialized and used by another module.

@achimnol achimnol added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 828efc9 Dec 7, 2023
25 checks passed
@achimnol achimnol deleted the fix/health-check-task-attribute branch December 7, 2023 08:34
achimnol pushed a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:general General platform issues. Most issues are general. size:S 10~30 LoC type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: Runner object has no attribute _health_check_task while shutting down
2 participants