-
Notifications
You must be signed in to change notification settings - Fork 12
fix: enhance SSH security settings and randomize devbox password #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yun Pan <dinoallo@netc.it>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
…rfile Signed-off-by: Yun Pan <dinoallo@netc.it>
Signed-off-by: Yun Pan <dinoallo@netc.it>
bdf6a83
to
ec2a5ef
Compare
Signed-off-by: Yun Pan <dinoallo@netc.it>
Signed-off-by: Yun Pan <dinoallo@netc.it>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances SSH security configuration and improves password security for Docker containers across multiple OS variants. The changes replace default passwords with randomly generated ones and strengthen SSH access controls.
- Replaces hardcoded "devbox" password with randomly generated passwords using OpenSSL
- Disables SSH password authentication and restricts root login to key-based authentication only
- Updates base images to use specific versions instead of latest tags
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
OS/ubuntu/24.04/Dockerfile | Adds SSH security settings and random password generation |
OS/ubuntu-cuda/24.04/Dockerfile | Applies same SSH security enhancements with password randomization |
OS/debian-ssh/12.6/Dockerfile | Updates base image, adds packages, and implements security improvements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Yun Pan <dinoallo@netc.it>
…directory Signed-off-by: Yun Pan <dinoallo@netc.it>
Signed-off-by: Yun Pan <dinoallo@netc.it>
No description provided.