Skip to content

Conversation

dinoallo
Copy link
Contributor

No description provided.

Signed-off-by: Yun Pan <dinoallo@netc.it>
@dinoallo dinoallo marked this pull request as draft August 13, 2025 11:04
@dinoallo dinoallo requested a review from Copilot August 13, 2025 11:04
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…rfile

Signed-off-by: Yun Pan <dinoallo@netc.it>
Signed-off-by: Yun Pan <dinoallo@netc.it>
@dinoallo dinoallo marked this pull request as ready for review August 13, 2025 14:36
@dinoallo dinoallo requested a review from Copilot August 13, 2025 14:36
@dinoallo dinoallo marked this pull request as draft August 13, 2025 14:36
@dinoallo dinoallo marked this pull request as ready for review August 13, 2025 14:38
Copilot

This comment was marked as outdated.

@dinoallo dinoallo force-pushed the enhancement/devbox-ssh branch from bdf6a83 to ec2a5ef Compare August 13, 2025 15:09
Signed-off-by: Yun Pan <dinoallo@netc.it>
@dinoallo dinoallo requested a review from Copilot August 13, 2025 15:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances SSH security configuration and improves password security for Docker containers across multiple OS variants. The changes replace default passwords with randomly generated ones and strengthen SSH access controls.

  • Replaces hardcoded "devbox" password with randomly generated passwords using OpenSSL
  • Disables SSH password authentication and restricts root login to key-based authentication only
  • Updates base images to use specific versions instead of latest tags

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
OS/ubuntu/24.04/Dockerfile Adds SSH security settings and random password generation
OS/ubuntu-cuda/24.04/Dockerfile Applies same SSH security enhancements with password randomization
OS/debian-ssh/12.6/Dockerfile Updates base image, adds packages, and implements security improvements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Yun Pan <dinoallo@netc.it>
…directory

Signed-off-by: Yun Pan <dinoallo@netc.it>
@zzjin zzjin merged commit a5f75b3 into labring-actions:main Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants