Update Github CI flow to use Go 1.18, bump actions versions #2166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lammel please do a review for this PR |
lammel
approved these changes
May 2, 2022
|
Seems like the MacOS CI fails on master now for Go 1.18. The timeout middleware seems to trigger a race there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Github CI flow to use Go 1.18, bump action versions.
Note: Github flow used
go get -u golang.org/x/lint/golint@latestbut from Go 1.18 this way of installing commands is removed andgo install golang.org/x/lint/golint@latestshould be used. But go install is supported only from Go 1.16. So I dropped Go 1.15 from github flow at the moment.