fix: update kms key policy, sns policy, stackset instance creation #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
reviewed
Nov 15, 2023
| condition { | ||
| test = "StringEquals" | ||
| variable = "aws:PrincipleOrgID" | ||
| variable = "aws:PrincipalOrgID" |
afiune
reviewed
Nov 15, 2023
main.tf
Outdated
| data "aws_region" "current" {} | ||
| resource "aws_cloudformation_stack_set_instance" "lacework_stackset_instances" { | ||
| deployment_targets { | ||
| organizational_unit_ids = [var.organization_unit] |
There was a problem hiding this comment.
Is this only 1 org unit? or can this be multiple ones?
There was a problem hiding this comment.
Can be multiple! I've left like this ATM to match expectations of the generate command. If we want to make this an array (totally fine) we need to update generate.
Can do now or raise a separate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional updates required for member accounts to use SNS topic, add dependencies so stack can be torn down, and to create stackset instances so deployment occurs.