fix: more and more fixes #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
afiune
commented
Nov 16, 2023
afiune
commented
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune
force-pushed
the
afiune/more-fixes
branch
from
14fc2c8 to
7896ef5
Compare
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune
force-pushed
the
afiune/more-fixes
branch
from
c7d7f9c to
4ebd876
Compare
``` Result #1 HIGH IAM policy document uses wildcarded action 's3:*' ──────────────────────────────────────────────────────────────────────────────── main.tf:107-109 ──────────────────────────────────────────────────────────────────────────────── 94 data "aws_iam_policy_document" "lacework_copy_zip_files_role" { .. 107 ┌ actions = [ 108 │ "s3:*", 109 └ ] ... 118 } ``` Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
``` Result #1 HIGH IAM policy document uses sensitive action 's3:PutObject' on wildcarded resource 'ec025b26-4ef5-4d0e-80f7-b02f25e7c851' ──────────────────────────────────────────────────────────────────────────────── main.tf:115-118 ──────────────────────────────────────────────────────────────────────────────── 96 data "aws_iam_policy_document" "lacework_copy_zip_files_role" { .. 115 ┌ resources = [ 116 │ aws_s3_bucket.lacework_org_lambda.arn, 117 │ "${aws_s3_bucket.lacework_org_lambda.arn}/*", 118 └ ] ... 122 } ``` Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
PengyuanZhao
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.