Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix badengine issue for versions over 13 #1663

Closed
wants to merge 1 commit into from
Closed

Conversation

nbezzala
Copy link

@nbezzala nbezzala commented Jan 8, 2022

Fix for issue 1660 - #1660

@@ -75,7 +75,7 @@
"zuul": "^3.12.0"
},
"engines": {
"node": ">=6.4.0 !13"
"node": ">=6.4.0 || <13 >=14"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct; you want the <13 to be before the ||.

$ node
Welcome to Node.js v16.2.0.
Type ".help" for more information.
> const {satisfies} = require('semver')
undefined
> satisfies('v16.1.0', ">=6.4.0 || <13 >=14")
true
> satisfies('v13.1.0', ">=6.4.0 || <13 >=14")
true
> satisfies('v13.1.0', ">=6.4.0 <13 || >=14")
false
> satisfies('v16.1.0', ">=6.4.0 <13 || >=14")
true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened #1666 to make it easier for the maintainer to merge and release.

@niftylettuce
Copy link
Collaborator

v7.0.2 released https://github.com/visionmedia/superagent/releases/tag/v7.0.2

I had to publish with np --no-tests because of yarn test lint errors with eslint not parsing engines properly per mysticatea/eslint-plugin-node#315.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants