Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: fix invalid syntax in engines #1666

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

glasser
Copy link
Contributor

@glasser glasser commented Jan 11, 2022

! is not supported by the semver library. This fixes a regression in v7
when used with engine-strict mode.

While the change in this PR may look similar to the state before #1660,
it differs by using two pipe characters instead of one.

Fixes #1665.

`!` is not supported by the semver library. This fixes a regression in v7
when used with engine-strict mode.

While the change in this PR may look similar to the state before ladjs#1660, 
it differs by using two pipe characters instead of one.
@jcurlier
Copy link

+1

@niftylettuce niftylettuce merged commit e7acafb into ladjs:master Jan 11, 2022
@niftylettuce
Copy link
Collaborator

v7.0.2 released https://github.com/visionmedia/superagent/releases/tag/v7.0.2

I had to publish with np --no-tests because of yarn test lint errors with eslint not parsing engines properly per mysticatea/eslint-plugin-node#315.

@glasser
Copy link
Contributor Author

glasser commented Jan 11, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install 7.0.1 version on 16.12.0 Node
3 participants