Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3.4.0 #532

Merged
merged 12 commits into from
Jan 16, 2019
Merged

V3.4.0 #532

merged 12 commits into from
Jan 16, 2019

Conversation

rimiti
Copy link
Contributor

@rimiti rimiti commented Jan 15, 2019 •
edited
Loading

Hello,

  • PR-532 - Packages updated, pipeline more explicit, documentation updated (thanks @rimiti)
  • PR-517 - Documentation updated (thanks @oprogramador)
  • PR-513 - Use more robust Array instance check (thanks @rubendg)

Regards,

@rimiti rimiti added this to the v3.4.0 milestone Jan 15, 2019
@rimiti rimiti self-assigned this Jan 15, 2019
@coveralls
Copy link

coveralls commented Jan 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 351

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.285%
Totals Coverage Status
Change from base Build 330: 0.0%
Covered Lines: 136
Relevant Lines: 140
💛 - Coveralls

gjohnson
gjohnson approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@gjohnson gjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rimiti rimiti merged commit 60f8a9e into master Jan 16, 2019
@rimiti rimiti deleted the v3.4.0 branch January 16, 2019 07:39
@rimiti rimiti restored the v3.4.0 branch January 16, 2019 07:39
@rimiti rimiti deleted the v3.4.0 branch January 16, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjohnson gjohnson gjohnson approved these changes

@mikelax mikelax Awaiting requested review from mikelax

Assignees

@rimiti rimiti

Labels
enhancement
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rimiti @coveralls @gjohnson @theronic @rubendg @oprogramador