Redefine stop frame sentinel #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow 0 to be used as the new sentinel value. Allow the old sentinel value of -1 to continue to work while we transition to new value. The field is unsigned, so a value of 0 fits better than -1. Particularly since neither 0 nor -1 would have a sensible use as a `frameDelay`. Further, it will simplify the code if `0` is exluded as a possible delay for frames that are not stop frames.
This allows either the old or the new sentinel value to be used for stop frames.
The `frameDelay` is an `unsigned` quantity, so it can only be <= 0 when it is == 0. Since 0 was added as a new sentinel value for stop frames, the check above already handles this case.
Set a default delay value equivalent to a stop frame.
This was referenced Jul 18, 2021
This was referenced Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #935, #920, #925, #797
Redefine the stop frame sentinel value from
-1to0. Add backwards compatibility for-1, which can be removed later after data is updated. Make the"delay"field in XML files optional, with a default value of0, equivalent to the new stop frame sentinel value.