Changes to the script #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avanatiker
added
bug
|
My bad |
|
@Avanatiker What's the status on this? i just build the project with this script on my freshly installed crappy laptop and i can confirm it works fine. |
|
The build script may be unsafe according to my IDEA: In POSIX sh, SECONDS is undefined. See SC2039. Line 29. What does it mean? |
Yeah POSIX is some ancient linux bash standard or something but on most distros this should work just fine and if it doesn't, the elapsed time will just show 0 minutes and 0 seconds |
Avanatiker
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the script now also generates the IntelliJ runs because why not