Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username & InventoryViewer Improvement #354

Merged
merged 8 commits into from
Aug 6, 2022
Merged

Username & InventoryViewer Improvement #354

merged 8 commits into from
Aug 6, 2022

Conversation

MellDa1024
Copy link
Contributor

@MellDa1024 MellDa1024 commented Aug 3, 2022

Describe the pull

Username fix

(Fixes 1-space blank when prefix or suffix is defined with blank)

Improved InventoryViewer, especially enderchest part.

Fixed EnderChest Desync Problem(Desyncs when player close ender chest and moves item at same time) with using CPacketCloseWindow Listener.

Now catches Ender chest in any language(original method didn't work when player had different langauge setting) with using TextComponentTranslation.key instead of name(This method needed to use SPacketOpenWindow).

Describe how this pull is helpful
better Performance

Additional context
well It's the first time that i'm opening the pull request, idk am i doing right but anyways
and I couldn't find the part that could cause bug but didn't test on high-ping(i don't know the high-ping environment has a potential power that could cause error, but anyways)

MellDa1024 and others added 3 commits August 3, 2022 12:50
Fixes 1-space blank when prefix or suffix is defined with blank
…est and moved item at same time), Now catches Ender chest in any language with using TextComponentTranslation.key instead of name(This method needed to use SPacketOpenWindow.
@MellDa1024 MellDa1024 changed the title Username & Username & InventoryViewer Improvement Aug 3, 2022
@Avanatiker
Copy link
Member

thanks for your contribution :) can you allow maintainers to push on your branch? i wanna push smol refactoring

@MellDa1024
Copy link
Contributor Author

Well I'm sorry for saying this but how can i allow it? I'm really new wth this type of job
image

@Avanatiker Avanatiker merged commit 16ad9e2 into lambda-client:master Aug 6, 2022
@mmvanheusden
Copy link
Contributor

That's the most professional first pull request i've ever seen. Hats off!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants