Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Server List" button in the Minecraft ESC GUI #472

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

Baitinq
Copy link
Contributor

@Baitinq Baitinq commented Jan 21, 2023

This patch adds a new "Server List" button replacing the disabled "Open To Lan" button in the multiplayer pause menu :)

@Avanatiker
Copy link
Member

This is a neat feature but currently it will cause endless network exceptions because it is not properly disconnecting before logging into the new server. hook into connect and make sure to disconnect when selection the server

@Baitinq
Copy link
Contributor Author

Baitinq commented Jan 22, 2023

This is a neat feature but currently it will cause endless network exceptions because it is not properly disconnecting before logging into the new server. hook into connect and make sure to disconnect when selection the server

My bad, I assumed everything would work first try lmao. Fix in progress :)

@Avanatiker
Copy link
Member

The patch looks like it works :) But quickly switching between the servers may cause a kick with description: "Failed to login: null" not sure whats causing it though. maybe you can find it out?

This patch adds a new "Server List" button replacing the disabled
"Open To Lan" button in the multiplayer pause menu :)
@Avanatiker Avanatiker merged commit fbeab41 into lambda-client:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants