Freecam Schematica Compatibility #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
Fixes Freecam compatibility with Schematica (still requires Entropy5's schematica fork with freecam fix)
Describe how this pull is helpful
Schematica is a popular mod and using freecam while building a schematic is helpful.
Additional context
The redirect mixin used here may be incompatible with certain other clients, see kami-blue/client#1886 and kami-blue/client#1950. I've tested this with Future and Rusherhack with no issues though.
Why we need this redirect and our previous ViewFrustum injection does not work is caused by this ViewFrustumOverlay in Schematica.
We need Schematica to render using the freecammed player's view, but we also need MC to update chunks using the non-freecammed player's view (otherwise we get ghost chunks when we turn off freecam).
Definitely open to suggestions for alternate solutions though.