-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(hints) Implement new hints #35 and #36 #1033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcenteno
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 21, 2023 20:00
Benchmark Results for unmodified programs 🚀
|
Oppen
approved these changes
Apr 21, 2023
MegaRedHand
approved these changes
Apr 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
- Coverage 98.08% 98.07% -0.02%
==========================================
Files 79 80 +1
Lines 32802 33033 +231
==========================================
+ Hits 32175 32398 +223
- Misses 627 635 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
reviewed
Apr 24, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
…mbdaclass#1033) * Implement BigInt5 * Implement hints 35 and 36 * Fix typo bug * Add changes to CHANGELOG * Fix broken build on WASM target * Address Pelito's suggestion * Fix sign check --------- Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat(hints) Implement new hints #35 and #36
Description
This PR adds the missing hints NewHint#35 and NewHint#36, now known as
BIGINT_PACK_DIV_MOD
andBIGINT_SAFE_DIV
as requested by the issue #975.Checklist