Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin Cairo compiler version #1220

Merged
merged 1 commit into from
Jun 12, 2023
Merged

fix: pin Cairo compiler version #1220

merged 1 commit into from
Jun 12, 2023

Conversation

Oppen
Copy link
Member

@Oppen Oppen commented Jun 10, 2023

Pins the compiler version to avoid build errors.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #1220 (6bf5630) into main (2b7de08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1220   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          89       89           
  Lines       36163    36163           
=======================================
  Hits        35293    35293           
  Misses        870      870           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 14.930 ± 0.167 14.698 15.237 1.00
head blake2s_integration_benchmark 15.036 ± 0.242 14.762 15.512 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 5.052 ± 0.106 4.930 5.267 1.00
head compare_arrays_200000 5.156 ± 0.112 4.896 5.278 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.285 ± 0.069 3.196 3.378 1.01 ± 0.03
head dict_integration_benchmark 3.262 ± 0.076 3.151 3.405 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 5.263 ± 0.083 5.162 5.415 1.00
head factorial_multirun 5.364 ± 0.069 5.237 5.439 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.480 ± 0.083 4.338 4.603 1.00
head fibonacci_1000_multirun 4.489 ± 0.079 4.346 4.602 1.00 ± 0.03
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 197.4 ± 9.2 186.3 214.5 1.03 ± 0.06
head field_arithmetic_get_square_benchmark 192.1 ± 7.8 186.3 213.2 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 13.599 ± 0.301 13.294 14.348 1.01 ± 0.02
head integration_builtins 13.406 ± 0.136 13.196 13.589 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 15.731 ± 0.441 15.130 16.658 1.02 ± 0.04
head keccak_integration_benchmark 15.403 ± 0.344 14.976 16.149 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.937 ± 0.041 4.875 4.994 1.00 ± 0.02
head linear_search 4.923 ± 0.082 4.801 5.052 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.531 ± 0.056 3.458 3.621 1.02 ± 0.03
head math_cmp_and_pow_integration_benchmark 3.470 ± 0.076 3.392 3.662 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.253 ± 0.028 3.203 3.295 1.01 ± 0.02
head math_integration_benchmark 3.213 ± 0.050 3.169 3.328 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.849 ± 0.031 2.807 2.910 1.01 ± 0.02
head memory_integration_benchmark 2.812 ± 0.036 2.748 2.861 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 3.171 ± 0.040 3.113 3.254 1.01 ± 0.02
head operations_with_data_structures_benchmarks 3.153 ± 0.047 3.086 3.245 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.119 ± 0.018 1.095 1.152 1.01 ± 0.03
head pedersen 1.110 ± 0.030 1.077 1.185 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.966 ± 0.024 1.942 2.008 1.00
head poseidon_integration_benchmark 2.011 ± 0.026 1.962 2.049 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.894 ± 0.074 3.791 4.015 1.01 ± 0.02
head secp_integration_benchmark 3.870 ± 0.057 3.797 3.966 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.287 ± 0.030 2.223 2.330 1.01 ± 0.02
head set_integration_benchmark 2.257 ± 0.040 2.193 2.303 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 8.638 ± 0.148 8.426 8.941 1.00
head uint256_integration_benchmark 8.881 ± 0.204 8.651 9.346 1.03 ± 0.03

@pefontana pefontana added this pull request to the merge queue Jun 12, 2023
Merged via the queue into main with commit 73539d3 Jun 12, 2023
31 checks passed
@pefontana pefontana deleted the fix/pin_cairo_version branch June 12, 2023 17:22
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants