Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uint256_div_mod.cairo entrypoint #1639

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

pefontana
Copy link
Member

@pefontana pefontana commented Feb 26, 2024

Fix uint256_div_mod.cairo entrypoint

Change the entrypoint offset to test the uint256_div_mod.cairo program, since it has changed due to compilation updates

@pefontana pefontana added the tests Implementation of tests label Feb 26, 2024
Copy link

github-actions bot commented Feb 26, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.274 ± 0.017 2.257 2.301 1.00
head big_factorial 2.282 ± 0.015 2.256 2.297 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.292 ± 0.038 2.266 2.397 1.00 ± 0.02
head big_fibonacci 2.287 ± 0.033 2.267 2.378 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.576 ± 0.064 8.454 8.638 1.00 ± 0.02
head blake2s_integration_benchmark 8.556 ± 0.159 8.344 8.892 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.334 ± 0.027 2.306 2.383 1.00
head compare_arrays_200000 2.365 ± 0.063 2.308 2.509 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.469 ± 0.040 1.435 1.553 1.02 ± 0.04
head dict_integration_benchmark 1.446 ± 0.033 1.415 1.505 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.303 ± 0.005 1.292 1.310 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.301 ± 0.008 1.290 1.312 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.524 ± 0.103 8.360 8.632 1.00
head integration_builtins 8.553 ± 0.135 8.364 8.802 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.788 ± 0.111 8.607 9.000 1.00
head keccak_integration_benchmark 8.809 ± 0.096 8.639 8.913 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.352 ± 0.015 2.333 2.371 1.00
head linear_search 2.356 ± 0.022 2.332 2.408 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.589 ± 0.038 1.557 1.687 1.01 ± 0.03
head math_cmp_and_pow_integration_benchmark 1.575 ± 0.015 1.555 1.593 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.435 ± 0.018 1.414 1.460 1.00
head math_integration_benchmark 1.435 ± 0.016 1.413 1.455 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.271 ± 0.018 1.248 1.307 1.00
head memory_integration_benchmark 1.284 ± 0.026 1.247 1.338 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.614 ± 0.011 1.598 1.635 1.00
head operations_with_data_structures_benchmarks 1.628 ± 0.035 1.602 1.723 1.01 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 593.0 ± 3.5 590.5 602.2 1.00
head pedersen 594.5 ± 9.2 586.4 616.0 1.00 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 979.3 ± 5.0 969.1 985.2 1.00
head poseidon_integration_benchmark 982.0 ± 15.9 967.7 1011.0 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.897 ± 0.025 1.873 1.947 1.01 ± 0.02
head secp_integration_benchmark 1.880 ± 0.020 1.868 1.937 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 727.7 ± 4.4 721.5 736.9 1.00
head set_integration_benchmark 728.5 ± 7.0 719.6 740.3 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.679 ± 0.038 4.630 4.757 1.00
head uint256_integration_benchmark 4.693 ± 0.115 4.627 5.016 1.00 ± 0.03

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (3547089) to head (219a4e8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1639   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          91       91           
  Lines       37393    37393           
=======================================
  Hits        36523    36523           
  Misses        870      870           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanbono juanbono added this pull request to the merge queue Feb 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2024
@pefontana pefontana added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit bdcfb1f Feb 26, 2024
51 checks passed
@pefontana pefontana deleted the fix-uint256_div_mod-entrypoint branch February 26, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Implementation of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants