-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uint256_div_mod.cairo entrypoint #1639
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pefontana
requested review from
igaray,
Oppen,
fmoletta,
entropidelic and
juanbono
as code owners
February 26, 2024 20:29
Benchmark Results for unmodified programs 🚀
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1639 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 91 91
Lines 37393 37393
=======================================
Hits 36523 36523
Misses 870 870 ☔ View full report in Codecov by Sentry. |
juanbono
approved these changes
Feb 26, 2024
igaray
approved these changes
Feb 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 26, 2024
This was referenced Feb 27, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix uint256_div_mod.cairo entrypoint
Change the entrypoint offset to test the uint256_div_mod.cairo program, since it has changed due to compilation updates