Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Felt to Felt252 #899

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Rename Felt to Felt252 #899

merged 1 commit into from
Mar 15, 2023

Conversation

Oppen
Copy link
Member

@Oppen Oppen commented Mar 15, 2023

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #899 (e76e2fe) into main (6790b25) will increase coverage by 97.38%.
The diff coverage is 98.28%.

@@            Coverage Diff            @@
##           main     #899       +/-   ##
=========================================
+ Coverage      0   97.38%   +97.38%     
=========================================
  Files         0       69       +69     
  Lines         0    29217    +29217     
=========================================
+ Hits          0    28454    +28454     
- Misses        0      763      +763     
Impacted Files Coverage Δ
src/hint_processor/hint_processor_definition.rs 100.00% <ø> (ø)
src/serde/deserialize_utils.rs 96.44% <71.42%> (ø)
...int_processor/builtin_hint_processor/math_utils.rs 97.75% <87.67%> (ø)
src/serde/deserialize_program.rs 97.86% <88.88%> (ø)
...uiltin_hint_processor/cairo_keccak/keccak_hints.rs 93.91% <89.47%> (ø)
src/vm/vm_memory/memory.rs 98.88% <97.22%> (ø)
src/types/relocatable.rs 99.67% <98.59%> (ø)
felt/src/lib.rs 89.43% <98.98%> (ø)
src/cairo_run.rs 98.52% <100.00%> (ø)
..._processor/builtin_hint_processor/blake2s_utils.rs 99.74% <100.00%> (ø)
... and 36 more

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanbono juanbono added this pull request to the merge queue Mar 15, 2023
Merged via the queue into main with commit 29e5580 Mar 15, 2023
@juanbono juanbono deleted the rename_felt252 branch March 15, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants