-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug locations #512
Add debug locations #512
Conversation
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
13.448 ± 0.042 | 13.402 | 13.549 | 30.90 ± 0.15 |
cairo-native (embedded AOT) |
1.550 ± 0.009 | 1.541 | 1.567 | 3.56 ± 0.02 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.522 ± 0.008 | 1.511 | 1.534 | 3.50 ± 0.02 |
cairo-native (standalone AOT) |
0.636 ± 0.002 | 0.634 | 0.638 | 1.46 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.435 ± 0.002 | 0.433 | 0.437 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
12.948 ± 0.032 | 12.904 | 13.021 | 1593.36 ± 18.14 |
cairo-native (embedded AOT) |
1.071 ± 0.008 | 1.052 | 1.079 | 131.80 ± 1.75 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.091 ± 0.006 | 1.082 | 1.101 | 134.23 ± 1.66 |
cairo-native (standalone AOT) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.01 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
1.824 ± 0.010 | 1.816 | 1.848 | 26.86 ± 0.17 |
cairo-native (embedded AOT) |
1.179 ± 0.007 | 1.167 | 1.189 | 17.37 ± 0.12 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.417 ± 0.006 | 1.408 | 1.425 | 20.87 ± 0.12 |
cairo-native (standalone AOT) |
0.112 ± 0.000 | 0.111 | 0.113 | 1.64 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.068 ± 0.000 | 0.068 | 0.069 | 1.00 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
==========================================
- Coverage 90.24% 90.09% -0.16%
==========================================
Files 107 107
Lines 34398 34480 +82
==========================================
+ Hits 31042 31064 +22
- Misses 3356 3416 +60 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
This just makes more locations show in the MLIR, sadly right now the locations dont get translated to llvm debug info as of yet.
Improved readme adding a section about debugging.
Also added better locations to know what libfunc is which MLIR instruction: