add unit tests for to_jit
#579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
edg-l,
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
+ Coverage 88.70% 88.95% +0.24%
==========================================
Files 108 108
Lines 34262 34480 +218
==========================================
+ Hits 30393 30672 +279
+ Misses 3869 3808 -61 ☔ View full report in Codecov by Sentry. |
edg-l
previously approved these changes
May 10, 2024
|
Looks good, but do we really need the indoc crate? it doesn't seem useful here since there isnt any indented text. |
Yes you are right, just removed it. |
edg-l
approved these changes
May 13, 2024
juanbono
approved these changes
May 13, 2024
Gerson2102
pushed a commit
to Gerson2102/cairo_native
that referenced
this pull request
May 15, 2024
* add unit tests for to_jit * remove uselesss indoc dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #482.
Checklist