Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored pedersen libfuncs to use the BlockExt trait #661

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

tcoratger
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 58.13953% with 18 lines in your changes missing coverage. Please review.

Project coverage is 91.82%. Comparing base (b2f1568) to head (56102a7).
Report is 9 commits behind head on main.

Files Patch % Lines
src/libfuncs/starknet.rs 0.00% 9 Missing ⚠️
src/libfuncs/ec.rs 25.00% 6 Missing ⚠️
src/libfuncs/array.rs 50.00% 1 Missing ⚠️
src/libfuncs/function_call.rs 0.00% 1 Missing ⚠️
src/types/box.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
- Coverage   91.95%   91.82%   -0.14%     
==========================================
  Files         112      113       +1     
  Lines       34265    34586     +321     
==========================================
+ Hits        31509    31759     +250     
- Misses       2756     2827      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l added the review-ready A PR that is ready for review label Jun 5, 2024
@edg-l edg-l added this pull request to the merge queue Jun 6, 2024
Merged via the queue into lambdaclass:main with commit 2c08c9e Jun 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants