Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imports #79

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Add imports #79

merged 2 commits into from
Jan 22, 2024

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Jan 16, 2024

Depends on #77

Current limitations (todo):

  • No support for absolute paths when calling a function
  • Import symbol renaming

See: #73

The following compiles:

mod Simple {
    import Other.{hello1};
    import Other.Deep.{hello2};

    fn main() -> i64 {
        return hello1(2) + hello2(2);
    }
}

mod Other {
    pub fn hello1(x: i64) -> i64 {
        return x * 2;
    }

    mod Deep {
        pub fn hello2(x: i64) -> i64 {
            return x * 4;
        }
    }
}

@edg-l edg-l changed the base branch from main to if_impl January 16, 2024 16:20
@edg-l edg-l marked this pull request as ready for review January 17, 2024 10:37
@edg-l edg-l mentioned this pull request Jan 17, 2024
2 tasks
Copy link
Member

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve error handling. We should specify the modules not found and things like that

Base automatically changed from if_impl to main January 18, 2024 12:42
@codecov-commenter
Copy link

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (4f68ec5) 68.74% compared to head (68423e9) 68.75%.

Files Patch % Lines
crates/concrete_codegen_mlir/src/ast_helper.rs 65.00% 28 Missing ⚠️
crates/concrete_codegen_mlir/src/codegen.rs 77.04% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   68.74%   68.75%   +0.01%     
==========================================
  Files          27       28       +1     
  Lines        1187     1309     +122     
==========================================
+ Hits          816      900      +84     
- Misses        371      409      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@igaray igaray merged commit 4d5f4a8 into main Jan 22, 2024
4 checks passed
@igaray igaray deleted the add_imports branch January 22, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants