Feat(poly): Add Dense and Sparse Multilinear Polynomials #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatStiles
changed the title
PatStiles
changed the title
PatStiles
changed the title
PatStiles
force-pushed
the
feat/multilinear_poly
branch
2 times, most recently
from
0cbce62
to
9c7c4a2
Compare
PatStiles
force-pushed
the
feat/multilinear_poly
branch
from
9c7c4a2
to
25339bf
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
- Coverage 95.36% 95.31% -0.06%
==========================================
Files 140 143 +3
Lines 31393 31753 +360
==========================================
+ Hits 29938 30264 +326
- Misses 1455 1489 +34 ☔ View full report in Codecov by Sentry. |
diegokingston
previously approved these changes
Jan 11, 2024
| } | ||
|
|
||
| /// Evaluates `self` at the point `p` in O(n) time. | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Allow dead code in a public function shouldn't be needed
Comment on lines
113
to
107
| //TODO; remove asserts | ||
| pub fn extend(&mut self, other: &DenseMultilinearPolynomial<F>) { |
| assert_eq!(self.evals.len(), self.len); | ||
| } | ||
|
|
||
| pub fn merge( |
MauroToscano
previously approved these changes
Jan 18, 2024
PatStiles
dismissed stale reviews from MauroToscano and diegokingston
via
91f2b83
PatStiles
force-pushed
the
feat/multilinear_poly
branch
from
45f0257
to
91f2b83
Compare
diegokingston
previously approved these changes
Jan 22, 2024
5 tasks
MauroToscano
previously approved these changes
Jan 23, 2024
PatStiles
dismissed stale reviews from MauroToscano and diegokingston
via
91f2b83
PatStiles
force-pushed
the
feat/multilinear_poly
branch
from
e6da920
to
91f2b83
Compare
MauroToscano
previously approved these changes
Jan 23, 2024
diegokingston
previously approved these changes
Jan 23, 2024
| } | ||
| } | ||
|
|
||
| fn get_bits(n: usize, num_bits: usize) -> Vec<bool> { |
There was a problem hiding this comment.
It would be nice to have some docs about this function
entropidelic
previously approved these changes
Jan 23, 2024
PatStiles
dismissed stale reviews from entropidelic, diegokingston, and MauroToscano
via
a5ce3b0
PatStiles
force-pushed
the
feat/multilinear_poly
branch
from
071e326
to
a5ce3b0
Compare
diegokingston
approved these changes
Jan 23, 2024
MauroToscano
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dense Multilinear Polynomial
Description
Extends the polyomial module by adding a Dense representation of a multilinear polynomial in lagrange basis.
Type of change
Please delete options that are not relevant.
Checklist