Skip to content

Conversation

leo-ppp
Copy link
Contributor

@leo-ppp leo-ppp commented Oct 26, 2022

This documentation is misleading; wrap-run hooks do not receive two arguments but a single one, being run. We can see this here

(wrap-run [run test-plan]
(reduce #(%2 %1) run (:kaocha.hooks/wrap-run test-plan)))

Writing a wrap-run hook that takes two arguments will throw an ArityException when running tests.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 75.47% // Head: 75.47% // No change to project coverage 👍

Coverage data is based on head (a9c4778) compared to base (c3b4bfb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   75.47%   75.47%           
=======================================
  Files          51       51           
  Lines        2732     2732           
  Branches      255      255           
=======================================
  Hits         2062     2062           
  Misses        510      510           
  Partials      160      160           
Flag Coverage Δ
integration 57.02% <ø> (ø)
unit 69.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alysbrooks
Copy link
Member

Thanks @leo-ppp!

@alysbrooks alysbrooks merged commit 5a64319 into lambdaisland:main Nov 3, 2022
@alysbrooks
Copy link
Member

GIF of someone writing THANK YOU out on a piece of paper and adding little triangular flairs around the edge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants