Filter non-linux packages from auto packages list #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imakunin
reviewed
Oct 7, 2023
imakunin
reviewed
Oct 7, 2023
futujaos
reviewed
Oct 9, 2023
futujaos
reviewed
Oct 9, 2023
| @@ -222,7 +236,7 @@ def _check_distribution_is_editable(self, distribution: Distribution) -> bool: | |||
| @lru_cache(maxsize=None) | |||
| def _check_distribution_at_pypi(pypi_index_url: str, name: str, version: str) -> bool: | |||
There was a problem hiding this comment.
btw, why we don't consider target_python here as we did in _check_distribution_platform_at_pypi?
There was a problem hiding this comment.
because we need to get two facts: if this package exists at pypi at all (because if it does not, we will treat it as LocalPackage) and if this package has an eligible platform for us.
futujaos
reviewed
Oct 9, 2023
futujaos
reviewed
Oct 9, 2023
| X-XSS-Protection: | ||
| - 1; mode=block | ||
| content-length: | ||
| - '3755' | ||
| status: | ||
| code: 200 | ||
| message: OK | ||
| - request: |
There was a problem hiding this comment.
looks too huge to place it in repo
maybe we can somehow keep only meaningful data in this mocked response?
There was a problem hiding this comment.
I think 2*2500 is not a big deal for git.
We definitely could shrink it, but it is extra work I don't want to do.
imakunin
reviewed
Oct 9, 2023
| @@ -19,6 +27,17 @@ | |||
| PIP_VERSION_REQ = "10.0.0" | |||
| PYPI_INDEX_URL_DEFAULT = PYPI_SIMPLE_ENDPOINT | |||
|
|
|||
| # TODO: obtain this information from server | |||
There was a problem hiding this comment.
let's make ticket for this problem
imakunin
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.