Drop ApplicationInterface #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xerkus
added a commit
to Xerkus/laminas-mvc
that referenced
this pull request
Jun 19, 2020
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Xerkus
force-pushed
the
feature/drop-application-interface
branch
from
b4bb224
to
e9e82bd
Compare
Xerkus
force-pushed
the
feature/drop-application-interface
branch
from
e9e82bd
to
f3338f2
Compare
Xerkus
force-pushed
the
feature/drop-application-interface
branch
from
f3338f2
to
68170d5
Compare
Xerkus
force-pushed
the
feature/drop-application-interface
branch
from
68170d5
to
870c61d
Compare
Xerkus
force-pushed
the
feature/drop-application-interface
branch
from
870c61d
to
b9c0040
Compare
ApplicationInterface was never properly utilized and some parts of the MVC application are implicitly depending on Laminas\Mvc\Application. It is not type safe and with the general direction towards dependency injection with container-exists-first approach there is hardly any value in keeping the interface. Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Xerkus
force-pushed
the
feature/drop-application-interface
branch
from
b9c0040
to
6b7cd1c
Compare
This was referenced Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ApplicationInterfacewas never really utilized and where application instance were expected often time it was theLaminas\Mvc\Applicationimplicitly which is not type safe.Interface does not provide a lot of value now and even more reduntant with the direction towards pure dependency injection from a mix of DI and service locator.
Make EventManager instance a required constructor parameter instead of optional pulled from injected container in the same constructor. Downgrade Application to
EventsCapableInterfaceremoving ability to set different event manager instance post instantiation.Psalm issues which are not directly related intentionally left unfixed to be handled in a separate PR.