Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds laminas-mvc in the conflict section of the Composer file for versions smaller than 3 #55

Closed

Conversation

froschdesign
Copy link
Member

The conflict definition was missed during updates in the past.

Fixes #29

@froschdesign froschdesign added the Bug Something isn't working label Jan 10, 2024
@froschdesign froschdesign added this to the 2.19.1 milestone Jan 10, 2024
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lock needs a refresh, but otherwise LGTM

@Xerkus
Copy link
Member

Xerkus commented Jan 10, 2024

This won't really help since earlier releases exist. I am not sure about conflict usefulness at this point

@froschdesign
Copy link
Member Author

@Xerkus
Good point! 🤔

@Xerkus
Copy link
Member

Xerkus commented Jan 10, 2024

I am inclined to declare this as wont fix at this point. Especially considering that no mvc v2 versions and current versions could be installed together because of no common php versions.

@froschdesign froschdesign removed this from the 2.19.1 milestone Jan 10, 2024
@froschdesign froschdesign deleted the hotfix/composer-conflict-mvc branch January 10, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants