phpstan fixes

[weierophinney]

This PR fixes some issues with phpdoc and types. Used phpstan to static analyse the code.

Added phpstan in CI build.

---

Originally posted by @thomasvargiu at zendframework/zend-servicemanager#272

[weierophinney]

I've added phpstan in CI build and fixed some wrong uses of array_key_exists with ArrayObject.

---

Originally posted by @thomasvargiu at zendframework/zend-servicemanager#272 (comment)

[weierophinney]

@thomasvargiu I've just noticed that this targets master: can you change it to develop? Since it's an improvement, it needs to target the next minor or major.

---

Originally posted by @Ocramius at zendframework/zend-servicemanager#272 (comment)

[weierophinney]

Please rebase, don't merge :)

---

Originally posted by @Ocramius at zendframework/zend-servicemanager#272 (comment)

[weierophinney]

My fault, I'm still working on it

---

Originally posted by @thomasvargiu at zendframework/zend-servicemanager#272 (comment)

[weierophinney]

@Ocramius
I have just one issue that I want to fix:

------ ----------------------------------------------------------------------------------------------------------------------------
  Line   src/AbstractPluginManager.php
 ------ ----------------------------------------------------------------------------------------------------------------------------
  130    Parameter #1 $instance of method Zend\ServiceManager\AbstractPluginManager::validate() expects object, array|object given.
 ------ ----------------------------------------------------------------------------------------------------------------------------

I think we should change PHPDoc of $instance parameter in Zend\ServiceManager\PluginManagerInterface::validate() from object to mixed because we know that services config key can contain anything.

But I'm not sure about this change. We can also ignore the error at the moment.

What do you think about it?

---

Originally posted by @thomasvargiu at zendframework/zend-servicemanager#272 (comment)

[weierophinney]

I've noted that phpstan should only be added for Travis jobs that require it, not as a general dev dependency.

Done.

Additionally, I'll note that a large number of the changes presented here are present in other pull requests; you'll likely need to rebase and run again once those are in place.

It's not a problem, when I open it I though that it could be useful before to introduce strict type hints. We can merge other PRs and then rebase it.

---

Originally posted by @thomasvargiu at zendframework/zend-servicemanager#272 (comment)

[weierophinney]

Rescheduling to 4.0.0 since it targets develop in turn targeting 4.0

---

Originally posted by @Xerkus at zendframework/zend-servicemanager#272 (comment)

[weierophinney]

@weierophinney I rebased it, updated phpstan, done some other fixes.

I also allowed array in the PluginManager validate() method.

---

Originally posted by @thomasvargiu at zendframework/zend-servicemanager#272 (comment)

[GeeH]

@laminas/technical-steering-committee is PHPStan fixes valid now or are we going all in with Psalm in the future? Do we see value in pull these changes across please?

[GeeH]

Ping @MWOP @Ocramius

[samsonasik]

Based on this https://github.com/laminas/technical-steering-committee/blob/c896c3af8fcbe0b3df82751e8bfeb54b536cc2e9/meetings/minutes/2020-08-03-TSC-Minutes.md#vote-on-static-analysis-tooling , we are going to use psalm.

I am closing this.