Decompile .tasty files with VS Code Extension #5513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 24, 2018 17:31
PartialTASTYDecompiler stops where the normal decompiler would traverse the tree
dottybot
reviewed
Nov 24, 2018
smarter
reviewed
Nov 24, 2018
You should open an issue on the vscode repository for this. |
An issue already exists for it: microsoft/vscode#2582 |
compiler/src/dotty/tools/dotc/decompiler/PartialTASTYDecompiler.scala
Outdated
Show resolved
Hide resolved
- Change Tasty -> TASTy as language alias - Override backendPhases instead of phases - Fix inefficient string concat in StringBuilder call - Fix printNat using Yellow directly instead of treeColor preventing override
nicolasstucki
approved these changes
Nov 28, 2018
|
@smarter do you have more comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This allows to view both decompiled scala source code and pretty printed TASTy tree when opening a
.tastyfile. The feature is similar to opening.classfiles in IntelliJ.As long as the language server supports the feature the IDE will automatically request decompilation when opening a
.tastyfile. No reason to make it an explicit action after opening the file considering they are not human readable.Decompilation errors are reported to the IDE, more specific errors can be added.
Errors currently reported:
Important: files need to be in the folder structure dictated by the package the class or object belongs to, otherwise class path will fail to resolve. To decompile
Thing.tastycontaining a classfoo.bar.Thingthe language server will look forfoo/bar/Thing.classandfoo/bar/Thing.tastyin class path.A minor inconvenience is that there is currently no way to bypass the binary file prompt in vscode, even when the file extension is defined in
package.json, so until that is allowed the user will always be prompted to confirm opening, and only then the decompile request will be sent.Screenshot
Result of opening
out/bootrstrap/dotty-language-server/scala-0.11/classes/dotty/tools/languageserver/Main.tasty: