Revert "Improve clarity in JSON loader documentation" #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ecfbd7c.
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes made in PR #742 that aimed to improve clarity in the JSON loader documentation. The revert restores the original documentation content and examples.
Key changes:
- Reverts simplified JSON example to original version with nested text structure
- Restores original output format in code examples
- Reverts grammatical and content changes made in the previous improvement attempt
| ### No JSON pointer example | ||
|
|
||
| The most simple way of using it is to specify no JSON pointer. | ||
| The most simple way of using it, is to specify no JSON pointer. |
There was a problem hiding this comment.
Grammatical error: unnecessary comma before 'is'. Should be 'The most simple way of using it is to specify no JSON pointer.'
Suggested change
| The most simple way of using it, is to specify no JSON pointer. | |
| The most simple way of using it is to specify no JSON pointer. |
Copilot uses AI. Check for mistakes.
| ### Using JSON pointer example | ||
|
|
||
| You can choose which keys in your JSON object you want to extract strings from. | ||
| You can do a more advanced scenario by choosing which keys in your JSON object you want to extract string from. |
There was a problem hiding this comment.
Grammatical error: 'string' should be plural 'strings' to match the context of extracting multiple text values.
Suggested change
| You can do a more advanced scenario by choosing which keys in your JSON object you want to extract string from. | |
| You can do a more advanced scenario by choosing which keys in your JSON object you want to extract strings from. |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #742