-
Notifications
You must be signed in to change notification settings - Fork 79
Revert "fix: correct links in quickstart guide of LangChain" #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 8e9dd3d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts a previous fix that corrected links in the LangChain quickstart guide. The revert undoes the link corrections, restoring the original (potentially incorrect) links that were previously fixed.
<Step title="Create tools"> | ||
[Tools](/oss/python/langchain/tools) let a model interact with external systems by calling functions you define. | ||
Tools can depend on [runtime context](/oss/python/langchain/runtime) and also interact with [agent memory](/oss/python/langchain/short-term-memory). | ||
Tools can depend on [runtime context](/oss/python/langchain/runtime) and also interact with [agent memory](/oss/python/langchain/memory). |
Copilot
AI
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link path /oss/python/langchain/memory
may be incorrect. Based on the original fix being reverted, this should likely be /oss/python/langchain/short-term-memory
to match the documentation structure.
Tools can depend on [runtime context](/oss/python/langchain/runtime) and also interact with [agent memory](/oss/python/langchain/memory). | |
Tools can depend on [runtime context](/oss/python/langchain/runtime) and also interact with [agent memory](/oss/python/langchain/short-term-memory). |
Copilot uses AI. Check for mistakes.
<Tip> | ||
Tools should be well-documented: their name, description, and argument names become part of the model's prompt. | ||
We've defined them here as plain Python functions, but LangChain's [@tool](/oss/python/langchain/tools#basic-tool-definition) decorator is often used to add extra metadata. | ||
We've defined them here as plain Python functions, but LangChain's [@tool](https://python.langchain.com/api_reference/core/tools/langchain_core.tools.base.tool.html#langchain_core.tools.convert.tool.html) decorator is often used to add extra metadata. |
Copilot
AI
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The external API reference link appears to have a malformed anchor fragment. The URL contains both a path (langchain_core.tools.base.tool.html
) and an anchor (#langchain_core.tools.convert.tool.html
), which may not resolve correctly.
We've defined them here as plain Python functions, but LangChain's [@tool](https://python.langchain.com/api_reference/core/tools/langchain_core.tools.base.tool.html#langchain_core.tools.convert.tool.html) decorator is often used to add extra metadata. | |
We've defined them here as plain Python functions, but LangChain's [@tool](https://python.langchain.com/api_reference/core/tools/langchain_core.tools.convert.tool.html) decorator is often used to add extra metadata. |
Copilot uses AI. Check for mistakes.
<Info> | ||
In production, use a persistent checkpointer that saves to a database. | ||
See [add and manage memory](/oss/python/langchain/short-term-memory#in-production) for more details. | ||
See [add and manage memory](/oss/python/python/langgraph/add-memory) for more details. |
Copilot
AI
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link path contains a duplicate 'python' segment (/oss/python/python/langgraph/add-memory
), making it an invalid internal link that will not resolve correctly.
See [add and manage memory](/oss/python/python/langgraph/add-memory) for more details. | |
See [add and manage memory](/oss/python/langgraph/add-memory) for more details. |
Copilot uses AI. Check for mistakes.
#782 changed here |
Reverts #764