Skip to content

Conversation

lnhsingh
Copy link
Collaborator

@lnhsingh lnhsingh commented Oct 7, 2025

Reverts #764

@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 19:34
@lnhsingh lnhsingh merged commit 90bc06e into prod Oct 7, 2025
1 check passed
@lnhsingh lnhsingh deleted the revert-764-patch-2 branch October 7, 2025 19:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous fix that corrected links in the LangChain quickstart guide. The revert undoes the link corrections, restoring the original (potentially incorrect) links that were previously fixed.

<Step title="Create tools">
[Tools](/oss/python/langchain/tools) let a model interact with external systems by calling functions you define.
Tools can depend on [runtime context](/oss/python/langchain/runtime) and also interact with [agent memory](/oss/python/langchain/short-term-memory).
Tools can depend on [runtime context](/oss/python/langchain/runtime) and also interact with [agent memory](/oss/python/langchain/memory).
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link path /oss/python/langchain/memory may be incorrect. Based on the original fix being reverted, this should likely be /oss/python/langchain/short-term-memory to match the documentation structure.

Suggested change
Tools can depend on [runtime context](/oss/python/langchain/runtime) and also interact with [agent memory](/oss/python/langchain/memory).
Tools can depend on [runtime context](/oss/python/langchain/runtime) and also interact with [agent memory](/oss/python/langchain/short-term-memory).

Copilot uses AI. Check for mistakes.

<Tip>
Tools should be well-documented: their name, description, and argument names become part of the model's prompt.
We've defined them here as plain Python functions, but LangChain's [@tool](/oss/python/langchain/tools#basic-tool-definition) decorator is often used to add extra metadata.
We've defined them here as plain Python functions, but LangChain's [@tool](https://python.langchain.com/api_reference/core/tools/langchain_core.tools.base.tool.html#langchain_core.tools.convert.tool.html) decorator is often used to add extra metadata.
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The external API reference link appears to have a malformed anchor fragment. The URL contains both a path (langchain_core.tools.base.tool.html) and an anchor (#langchain_core.tools.convert.tool.html), which may not resolve correctly.

Suggested change
We've defined them here as plain Python functions, but LangChain's [@tool](https://python.langchain.com/api_reference/core/tools/langchain_core.tools.base.tool.html#langchain_core.tools.convert.tool.html) decorator is often used to add extra metadata.
We've defined them here as plain Python functions, but LangChain's [@tool](https://python.langchain.com/api_reference/core/tools/langchain_core.tools.convert.tool.html) decorator is often used to add extra metadata.

Copilot uses AI. Check for mistakes.

<Info>
In production, use a persistent checkpointer that saves to a database.
See [add and manage memory](/oss/python/langchain/short-term-memory#in-production) for more details.
See [add and manage memory](/oss/python/python/langgraph/add-memory) for more details.
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link path contains a duplicate 'python' segment (/oss/python/python/langgraph/add-memory), making it an invalid internal link that will not resolve correctly.

Suggested change
See [add and manage memory](/oss/python/python/langgraph/add-memory) for more details.
See [add and manage memory](/oss/python/langgraph/add-memory) for more details.

Copilot uses AI. Check for mistakes.

@eyurtsev
Copy link
Collaborator

eyurtsev commented Oct 7, 2025

#782 changed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants