fix: homepage sidebar, dropdowns, typescript rename #886
+469
−1,172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hntrl
commented
Oct 14, 2025
hntrl
commented
- hides the homepage sidebar using the custom page mode
- makes the version picker a dropdown instead of a locale switcher
- from what I gather this is more performant
- should reduce the amount of info in the top bar
- renames "javascript" -> "typescript" in the language dropdown
- group consensus was this is better positioning with JS OSS devs
* hides the homepage sidebar using the custom page mode * makes the version picker a dropdown instead of a locale switcher * from what I gather this is more performant * should reduce the amount of info in the top bar * renames "javascript" -> "typescript" in the language dropdown * group consensus was this is better positioning with JS OSS devs
|
Preview ID generated: preview-hunter-1760457004-5636d94 |
|
does the icon in the language dropdown need to be TS instead of JS or does it not matter? |
|
Preview ID generated: preview-hunter-1760457724-420d712 |
mdrxy
pushed a commit
that referenced
this pull request
Oct 14, 2025
* hides the homepage sidebar using the custom page mode * makes the version picker a dropdown instead of a locale switcher * from what I gather this is more performant * should reduce the amount of info in the top bar * renames "javascript" -> "typescript" in the language dropdown * group consensus was this is better positioning with JS OSS devs Co-authored-by: Lauren Hirata Singh <lauren@langchain.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.