Add a Wrapper vectorstore, compatible with SelfQueryRetriever #13190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: vector store
pprados
force-pushed
the
pprados/wrapper_vectorstore
branch
9 times, most recently
from
91dcce0 to
3a9c4bd
Compare
14 tasks
pprados
added a commit
to pprados/langchain-rag
that referenced
this pull request
Nov 10, 2023
- [Add a Wrapper vectorstore, compatible with SelfQueryRetriever](langchain-ai/langchain#13190) - [Adds an in-memory implementation of RecordStore](langchain-ai/langchain#13200) - [Add SQLDocStore](langchain-ai/langchain#13181)
pprados
force-pushed
the
pprados/wrapper_vectorstore
branch
5 times, most recently
from
823f8dc to
a46378a
Compare
dosubot
bot
added
the
size:XL
pprados
force-pushed
the
pprados/wrapper_vectorstore
branch
from
268f6f2 to
0f47246
Compare
dosubot
bot
added
size:L
pprados
force-pushed
the
pprados/wrapper_vectorstore
branch
2 times, most recently
from
6378ab1 to
7042880
Compare
pprados
force-pushed
the
pprados/wrapper_vectorstore
branch
from
7042880 to
bfc12a4
Compare
dosubot
bot
added
size:XS
baskaryan
had a problem deploying
to
Scheduled testing
GitHub Actions
Failure
baskaryan
had a problem deploying
to
Scheduled testing
GitHub Actions
Error
baskaryan
had a problem deploying
to
Scheduled testing
GitHub Actions
Error
baskaryan
had a problem deploying
to
Scheduled testing
GitHub Actions
Error
|
@baskaryan, I see the pull request successfully merged and closed, but I not see the code in the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
SelfQueryRetrievercomponent is able to convert filter clauses for different vectorstore implementations.If we wish to offer advanced use of vectorstore, by modifying for example certain methods, via a wrapper type approach, we lose the ability to use
SelfQueryRetriever.We propose to standardize vectorstore wrapper exploitation, to allow flexible integration with
SelfQueryRetriever.The idea is to add to
_get_builtin_translator(), taking into account the wrapper.Thus, every vectorstore wrapper automatically benefits from the SelfQueryRetriever.
This is the prelude to another full-request, which needs a vectorstore wrapper, while being compatible
with
SelfQueryRetriever.Tag maintainer:
@baskaryan
Twitter handle:
@pprados