Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bedrock model runtime enhancement #6299

Merged
merged 1 commit into from
Jul 16, 2024
Merged

feat: bedrock model runtime enhancement #6299

merged 1 commit into from
Jul 16, 2024

Conversation

longzhihun
Copy link
Contributor

@longzhihun longzhihun commented Jul 15, 2024

…d model invoke method to converse api

Checklist:

Important

Please review the checklist below before submitting your pull request.

Description

  1. modify non stream tool use
  2. modify most of bedrock models invoking method to conversational api

Close #6298
Fix #6299

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 15, 2024
@crazywoola crazywoola changed the title [seanguo] 1. modify non stream tool use 2. modify converse api enabled model feat: bedrock model runtime enhancement Jul 16, 2024
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@laipz8200
Copy link
Collaborator

I think we can merge this PR first, then check how many models don't have a system prompt.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 16, 2024
@crazywoola crazywoola merged commit ed9e692 into langgenius:main Jul 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify most of bedrock model invoke method to converse api
3 participants