-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements #290
Various improvements #290
Conversation
Codecov Report
@@ Coverage Diff @@
## main #290 +/- ##
==========================================
+ Coverage 94.15% 94.21% +0.06%
==========================================
Files 49 53 +4
Lines 3269 3303 +34
==========================================
+ Hits 3078 3112 +34
Misses 191 191
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
"Iter": "%d", | ||
"Time": "%8.2e", | ||
} | ||
itstat_attrib = ["itnum", "timer.elapsed()"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This itstat initialization is always a stumbling block for me when reading the class. Could it be easily refactored into its own function/class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps. It would probably have to be some sort of private auxiliary class rather than a general utility, but that's worth considering. I'll make a separate issue as a reminder.
Split
admm
andpgm
modules into multiple source files for easier editing, and various other minor improvements.