Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cURL if available in FileGetContentsLoader #68

Closed
wants to merge 1 commit into from

Conversation

cKlee
Copy link

@cKlee cKlee commented Nov 18, 2015

This solves #67. It checks whether function curl_init exists and uses cURL then instead of file_get_contents.

Exception string correction

PHP 5.3 needs array()

resolve relative path to absolute

Follow PSR2 with CodeSniffer
@lanthaler
Copy link
Owner

Sorry for the late reply @cKlee. Could you please put this in a separate class CurlLoad instead of putting it into FileGetContentsLoader. The latter is called that way because it uses file_get_contents(). Also, now that PSR-7 (see issue #4) has been released, it would be possible to refactor this so that it would become very simple to use all sorts of libraries.

@cKlee
Copy link
Author

cKlee commented Dec 29, 2015

Further discussion at #4

@cKlee cKlee closed this Dec 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants