Skip to content

Removes wait for app boot for routes registration #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Removes wait for app boot for routes registration #2

merged 1 commit into from
Dec 11, 2019

Conversation

vladkucherov
Copy link
Contributor

Waiting for app to boot causes the routes to register late, at the end of the routes list.
May cause overriding of user defined routes.
Or in my case, a "catch all" route which caught the _grid-sortable_ route (because it was prior in the routes list).

Waiting for app to boot causes the routes to register late, at the end of the routes list.
May cause overriding use defined routes.
Or in my case, a "catch all" route which caught the `_grid-sortable_` route (because it was prior in the routes list).
@z-song z-song merged commit 6fc0af7 into laravel-admin-extensions:master Dec 11, 2019
@z-song
Copy link
Member

z-song commented Dec 11, 2019

Thanks!

@vladkucherov vladkucherov deleted the patch-1 branch December 11, 2019 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants