Add PHP 8.4 support #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lanatel
force-pushed
the
add-php-8.4-support
branch
from
7c190d9 to
81d9e88
Compare
|
Hi @TomHAnderson , would you be able to create a new tag when you have a moment? Also, I noticed a StyleCI failure after the merge - it seems unrelated to my changes (the flagged file wasn't modified in the PR), but I'm happy to open a follow-up PR to fix it if needed. Thanks! |
|
I waited on the tag because of the CI failure. I would appreciate it if you'd look into that. This library is an odd duck. But as long as folks like yourself are using it, I'll continue to maintain it. |
|
@TomHAnderson I’ve opened a new PR with the fixes: #84. Let me know if anything else is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for PHP 8.4 by updating the CI workflow and ensuring compatibility.
Deprecation notices were appearing under PHP 8.4, such as: