Improved checking if framework is Lumen or not

[gcamrit]

No description provided.

[ryan-senn]

If this pull-request gets accepted, don't forget to replicate it for the MigrationsServiceProvider and AclServiceProvider!

[patrickbrouwers]

Is ->version() available on the Application contract?

[gcamrit]

yes it is available on Application Contract

[patrickbrouwers]

Nice. Can you rebase your commits for me (squash into 1 commit) :)

[gcamrit]

Right now, i don't have my laptop. will it be a problem to do it with 2 commit ?

[patrickbrouwers]

You can select the last to commits with git rebase -i HEAD~2

[gcamrit]

I don't know what am i doing with git .. learning to use it :)

@patrickbrouwers i run that command you gave me and squash my last commit and pushed it

[patrickbrouwers]

Hmm that didn't work out haha :p

Try to follow these steps:

git checkout 1.0
git rebase -i HEAD~4

Change the last 3 commits to f instead of p. Keep the first commit on p.

Close the window (and save the file)

git push -f

---

Alos what seems to have gone wrong is that you tracked master into 1.0. Make sure you are in the 1.0 branch.

[gcamrit]

Finally it is in one commit now :)

[patrickbrouwers]

Good job, @Amrit01 ! :)

P.S. Only see now that you made the PR to the master branch. These kind of fixes can go to 1.0 . Master is only for breaking changes/big new functionality.

Can you make PR to the 1.0 branches of the other packages to include this fix?