Avoid unnecessary query in ModelLoader #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindyhopchris
requested changes
Mar 12, 2023
|
Thanks, replaced the code with your suggestion. |
|
@lindyhopchris Can you merge the PR now? |
|
Sorry, thanks for the prompt! Yeah will merge and tag this weekend. |
lindyhopchris
approved these changes
Apr 3, 2023
|
Apologies this took a while. Tagged as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For queries to a single resource (e.g.
v1/pages/1) for which no relations should be fetched, there's an unnecessary query executed:This is because
$this->queryParameters->countable()returnsNULLhere:https://github.com/laravel-json-api/eloquent/blob/develop/src/QueryOne.php#L125
The patch checks for
NULLvalues and avoids that query in this case.